Repository navigation
Remove mai from SUFFIX_ACRONYMS so a trailing Mai keeps the name - #698
Merged
Merged
Conversation
MAI (Member, Appraisal Institute) is a specialized US credential; Mai is a common Vietnamese given and family name, a Chinese surname and a Japanese given name. The entry came from the 2019-12-11 bulk post-nominal import and was never reviewed. By the relative-frequency criterion of decisions.md#suffix-acronym-collisions the name reading dominates, so the entry is removed, as rai and cha were. "Tran Thi Mai" under FAMILY_FIRST_GIVEN_LAST now reads given Mai, middle Thi, family Tran (was suffix Mai); "Nguyen Mai" reads family Mai. The accepted cost: "John Smith MAI" reads family MAI. "Smith, John, MAI" and "John Smith M.A.I." still read suffix. One snapshot name moves (Tran Thi Mai, FAMILY_FIRST); the conventions agreement record gains two progress entries. Closes #687 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #698 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 46 46
Lines 4541 4541
=======================================
Hits 4497 4497
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #687.
mai(MAI, Member, Appraisal Institute) came from the unreviewed 2019 bulk post-nominal import and swallowed the nameMaiin trailing position. By the relative-frequency criterion indecisions.md#suffix-acronym-collisionsthe name reading dominates, so the entry is removed (therai/chaoutcome), not marked ambiguous.Effect
Tran Thi Mai(FAMILY_FIRST_GIVEN_LAST): suffixMai→ givenMai, middleThi, familyTranNguyen Mai: suffixMai→ familyMai(1.4.0's reading)John Smith MAI→ familyMAI.Smith, John, MAIandJohn Smith M.A.I.still read suffix.Changes:
suffixes.py; three case rows; decisions.md bullet; release-log bullet; snapshot re-recorded (1 name moves); conventions agreement record gains 2 progress entries.Verified: full suite 20,338 passed, ruff, mypy, and docs doctests clean. 1.4.0 wheel checked for the parity claims. JA locale agreement rows were not re-measured (namedivider not installed).
🤖 Generated with Claude Code